[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pgsql-hackers
Subject:    Re: [HACKERS] Add on_perl_init and proper destruction to plperl UPDATE v3 [PATCH]
From:       Andrew Dunstan <andrew () dunslane ! net>
Date:       2010-01-30 2:10:48
Message-ID: 4B639528.6060907 () dunslane ! net
[Download RAW message or body]



Tim Bunce wrote:
> This is an updated version of the third of the patches to be
> split out from the former 'plperl feature patch 1'.
>
> It includes changes following discussions with Tom Lane and others.
>
> Changes in this patch:
>
> - Added plperl.on_perl_init GUC for DBA use (PGC_SIGHUP)
>    SPI functions are not available when the code is run.
>
> - Added interpreter destruction behaviour
>    Hooked via on_proc_exit().
>    Only has any effect for normal shutdown.
>    END blocks, if any, are run.
>    SPI functions will die if called at this time.
>
> This updated version no longer tries to call object destructors.
> I've added a note in the Limitations section of the PL/Perl docs.
> It also adds a PERL_SET_CONTEXT() that's needed but was missing.
>
>   

I have committed this. The final thing that persuaded me that no great 
damage would be done by on_perl_init was the realization that we already 
have the ability to do more or less the same thing anyway via standard 
Perl mechanisms, and I'd be very surprised if enterprising Perl users 
hadn't made use of it.

My impression is that the on_trusted_init and on_untrusted_init settings 
that are in the next patch are a bit less controversial.

Tim, can you rebase the last two patches against current CVS HEAD?

cheers

andrew

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
[prev in list] [next in list] [prev in thread] [next in thread]