[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pgsql-committers
Subject:    pgsql: Fix query result leak during binary upgrade
From:       Daniel Gustafsson <dgustafsson () postgresql ! org>
Date:       2024-05-15 20:54:39
Message-ID: E1s7Le3-000O4t-J2 () gemulon ! postgresql ! org
[Download RAW message or body]

[Attachment #2 (text/plain)]

Fix query result leak during binary upgrade

9a974cbcba00 moved the query in binary_upgrade_set_pg_class_oids to the
outer level, but left the PQclear and query buffer destruction in the
is_index conditional.  353708e1fb2d fixed the leak of the query buffer
but left the PGresult leak. This moves clearing the result to the outer
level ensuring that it will be called.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/374550C1-F4ED-4D9D-9498-0FD029CCF674@yesql.se
Backpatch-through: v15

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e6fc3b70df906868df36517c2c7c5a38725e1451

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



[prev in list] [next in list] [prev in thread] [next in thread]