[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pgsql-committers
Subject:    pgsql: Ensure acquire_inherited_sample_rows sets its output parameters.
From:       Tom Lane <tgl () sss ! pgh ! pa ! us>
Date:       2023-03-31 14:08:51
Message-ID: E1piFQw-000f8g-J3 () gemulon ! postgresql ! org
[Download RAW message or body]

[Attachment #2 (text/plain)]

Ensure acquire_inherited_sample_rows sets its output parameters.

The totalrows/totaldeadrows outputs were left uninitialized in cases
where we find no analyzable child tables of a partitioned table.  This
could lead to setting the partitioned table's pg_class.reltuples value
to garbage.  It's not clear that that would have any very bad effects
in practice, but fix it anyway because it's making valgrind unhappy.

Reported and diagnosed by Alexander Lakhin (bug #17880).

Discussion: https://postgr.es/m/17880-9282037c923d856e@postgresql.org

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2dcd92e97dfa8c5808bcb6ee0f21327a052eac96

Modified Files
--------------
src/backend/commands/analyze.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)



[prev in list] [next in list] [prev in thread] [next in thread]