[prev in list] [next in list] [prev in thread] [next in thread]
List: pgsql-committers
Subject: pgsql: Cache the results of format_type() queries in pg_dump.
From: Tom Lane <tgl () sss ! pgh ! pa ! us>
Date: 2021-08-31 17:54:12
Message-ID: E1mL7xc-0004AY-Go () gemulon ! postgresql ! org
[Download RAW message or body]
[Attachment #2 (text/plain)]
Cache the results of format_type() queries in pg_dump.
There's long been a "TODO: there might be some value in caching
the results" annotation on pg_dump's getFormattedTypeName function;
but we hadn't gotten around to checking what it was costing us to
repetitively look up type names. It turns out that when dumping the
current regression database, about 10% of the total number of queries
issued are duplicative format_type() queries. However, Hubert Depesz
Lubaczewski reported a not-unusual case where these account for over
half of the queries issued by pg_dump. Individually these queries
aren't expensive, but when network lag is a factor, they add up to a
problem. We can very easily add some caching to getFormattedTypeName
to solve it.
Since this is such a simple fix and can have a visible performance
benefit, back-patch to all supported branches.
Discussion: https://postgr.es/m/20210826084430.GA26282@depesz.com
Branch
------
REL_11_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/c4b298ee15aa67a953e65c8efa1a33eeea721446
Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 13 +++++++++++--
src/bin/pg_dump/pg_dump.h | 6 ++++--
2 files changed, 15 insertions(+), 4 deletions(-)
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic