[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pgsql-committers
Subject:    pgsql: Fix libpq state machine in pipeline mode
From:       Alvaro Herrera <alvherre () alvh ! no-ip ! org>
Date:       2021-06-29 19:06:30
Message-ID: E1lyJ42-0001gD-8T () gemulon ! postgresql ! org
[Download RAW message or body]

[Attachment #2 (text/plain)]

Fix libpq state machine in pipeline mode

The original coding required that PQpipelineSync had been called before
the first call to PQgetResult, and failure to do that would result in an
unexpected NULL result being returned.  Fix by setting the right state
when a query is sent, rather than leaving it unchanged and having
PQpipelineSync apply the necessary state change.

A new test case to verify the behavior is added, which relies on the new
PQsendFlushRequest() function added by commit a7192326c74d.

Backpatch to 14, where pipeline mode was added.

Reported-by: Boris Kolpackov <boris@codesynthesis.com>
Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m/boris.20210616110321@codesynthesis.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/690339fcd58759d213523f87071f992c4402e980

Modified Files
--------------
src/interfaces/libpq/fe-exec.c                     | 19 ++---
src/test/modules/libpq_pipeline/libpq_pipeline.c   | 90 +++++++++++++++++++++
.../modules/libpq_pipeline/t/001_libpq_pipeline.pl |  2 +-
.../modules/libpq_pipeline/traces/nosync.trace     | 92 ++++++++++++++++++++++
4 files changed, 188 insertions(+), 15 deletions(-)



[prev in list] [next in list] [prev in thread] [next in thread]