[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pgsql-committers
Subject:    pgsql: pg_waldump: Fix --bkp-details to not issue spurious newlines for
From:       Andres Freund <andres () anarazel ! de>
Date:       2019-10-30 5:58:56
Message-ID: E1iPh0S-0001RL-D5 () gemulon ! postgresql ! org
[Download RAW message or body]

[Attachment #2 (text/plain)]

pg_waldump: Fix --bkp-details to not issue spurious newlines for FPWs.

The additional newline seems to have accidentally been introduced in
2c03216d831, in 9.5. The newline is only issued when an FPW is
present for the block reference.

While there could be an argument that removing the newlines in the
back branches could cause a problem for somebody parsing the
pg_waldump output, the likelihood of that seems small enough. It seems
at least equally likely that the randomness of when newlines are
issued causes problems.

Author: Andres Freund
Discussion: https://postgr.es/m/20191029233341.4gnyau7e5v2lh5sc@alap3.anarazel.de
Backpatch: 9.5, like 2c03216d831.

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d4b5206b22374ddf99dbe31370d6d713881fb87c

Modified Files
--------------
src/bin/pg_waldump/pg_waldump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



[prev in list] [next in list] [prev in thread] [next in thread]