[prev in list] [next in list] [prev in thread] [next in thread]
List: pgsql-committers
Subject: pgsql: Fix bogus list-iteration code in pg_regress.c, affecting ecpg te
From: Tom Lane <tgl () sss ! pgh ! pa ! us>
Date: 2018-04-30 1:56:54
Message-ID: E1fCy3i-0004I6-3b () gemulon ! postgresql ! org
[Download RAW message or body]
Fix bogus list-iteration code in pg_regress.c, affecting ecpg tests only.
While looking at a recent buildfarm failure in the ecpg tests, I wondered
why the pg_regress output claimed the stderr part of the test failed, when
the regression diffs were clearly for the stdout part. Looking into it,
the reason is that pg_regress.c's logic for iterating over three parallel
lists is wrong, and has been wrong since it was written: it advances the
"tag" pointer at a different place in the loop than the other two pointers.
Fix that.
Branch
------
REL9_5_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/8d9e4d13dd6edd4165f1f82f06e07c6fccf1c0ea
Modified Files
--------------
src/test/regress/pg_regress.c | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic