[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pgsql-committers
Subject:    Re: [COMMITTERS] pgsql: Remove special cases for ETXTBSY from new fsync'ing logic.
From:       Andres Freund <andres () anarazel ! de>
Date:       2015-05-29 21:49:27
Message-ID: 20150529214927.GA6535 () alap3 ! anarazel ! de
[Download RAW message or body]

On 2015-05-29 19:11:58 +0000, Tom Lane wrote:
> Andres had brought it up back when we were
> still considering that most fsync failures should be hard errors, and it
> probably would be legit not to fail hard for ETXTBSY --- but the same is
> true for EROFS and other cases, which is why we gave up on hard failures.
> ETXTBSY is surely not a normal case, so logging the failure seems fine
> from here.

Note that EROFS etc should never happen without following symlinks,
whereas ETXTBSY conceivably could.


I'm fine though, with the special case being removed, I think you made a
good point that it's unlikely that e.g. an archive_command will run
during startup.


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
[prev in list] [next in list] [prev in thread] [next in thread]