[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pgsql-committers
Subject:    Re: [COMMITTERS] pgsql: Adjust initdb to also not consider fsync'ing failures fatal.
From:       Peter Eisentraut <peter_e () gmx ! net>
Date:       2015-05-29 19:59:18
Message-ID: 5568C516.6040909 () gmx ! net
[Download RAW message or body]

On 5/29/15 1:05 PM, Tom Lane wrote:
> Adjust initdb to also not consider fsync'ing failures fatal.

This introduces a failure in the initdb tests, which expect that

    initdb -S -D /notthere

returns a nonzero exit code.

The output of that command is also a bit crazy now:

$ pg-install/bin/initdb -S -D /notthere
syncing data to disk ... initdb: could not stat file
"/notthere/pg_xlog": No such file or directory
initdb: could not open directory "/notthere": No such file or directory
initdb: could not open directory "/notthere/pg_tblspc": No such file or
directory
ok


I think the behavior to ignore fsync failures should probably not apply
to top-level directories.  Or alternatively, the existence of these
directories should be checked separately.



-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
[prev in list] [next in list] [prev in thread] [next in thread]