[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pgsql-committers
Subject:    [COMMITTERS] pgsql: Fix AfterTriggerSaveEvent to use a test and elog, not just
From:       tgl () postgresql ! org (Tom Lane)
Date:       2009-10-27 20:14:40
Message-ID: 20091027201440.EDAC1753FB7 () cvs ! postgresql ! org
[Download RAW message or body]

Log Message:
-----------
Fix AfterTriggerSaveEvent to use a test and elog, not just Assert, to check
that it's called within an AfterTriggerBeginQuery/AfterTriggerEndQuery pair.
The RI cascade triggers suppress that overhead on the assumption that they
are always run non-deferred, so it's possible to violate the condition if
someone mistakenly changes pg_trigger to mark such a trigger deferred.
We don't really care about supporting that, but throwing an error instead
of crashing seems desirable.  Per report from Marcelo Costa.

Tags:
----
REL8_3_STABLE

Modified Files:
--------------
    pgsql/src/backend/commands:
        trigger.c (r1.227.2.2 -> r1.227.2.3)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/trigger.c?r1=1.227.2.2&r2=1.227.2.3)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[prev in list] [next in list] [prev in thread] [next in thread]