[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pgsql-bugs
Subject:    Re: BUG #17879: ERROR: unrecognized node type: 2139062143
From:       David Rowley <dgrowleyml () gmail ! com>
Date:       2023-03-30 23:19:08
Message-ID: CAApHDvpX39pgamk4Ryr7qHMO4yo2kDRjbU5EvMZaSDQX9=RAxQ () mail ! gmail ! com
[Download RAW message or body]

On Thu, 30 Mar 2023 at 23:54, David Rowley <dgrowleyml@gmail.com> wrote:
> I see a few ways to fix; 1) always make a list_copy() of the list
> before calling generateSerialExtraStmts(), or; 2) make a copy of the
> list inside generateSerialExtraStmts() unconditionally, or 3) at the
> very least, just make a copy before calling list_delete_nth_cell().

I ended up pushing #2 as a fix. It just seems nicer to make sure that
the new command gets a completely different copy of the List in all
cases.  That seems likely to reduce the chances of any future bugs
that might be caused if we ever add future code which modifies the
input list.

The fix will appear in 15.3

Thanks again for reporting this.

David


[prev in list] [next in list] [prev in thread] [next in thread]