[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pgsql-bugs
Subject:    Re: BUG #16329: Valgrind detects an invalid read when building a gist index with buffering
From:       Tom Lane <tgl () sss ! pgh ! pa ! us>
Date:       2023-03-30 11:47:29
Message-ID: 2601.1680176849 () sss ! pgh ! pa ! us
[Download RAW message or body]

Alexander Lakhin <exclusion@gmail.com> writes:
> As to that concrete place, I would incline to improve the test while it =
stays
> in line with other tests, but I lack a whole picture of the gist testing=
.
> It doesn't seem to me that the regress/sql/gist.sql is too comprehensive=
.
> I've just looked at the scan-build's results and found 9 warnings relate=
d to
> gist. A quick glance at the code confirms that there are indeed
> interesting cases, which are not exercised for now (e.g., call
> gistRelocateBuildBuffersOnSplit() with
> IndexRelationGetNumberOfKeyAttributes(r) > 1).
> So if I could prove that 2-3 of them are really bugs during the next wee=
k,
> maybe then assess that test change alongside with others (if any).
> (Maybe we'll want to build that index over different columns, for exampl=
e.)

OK, there's certainly no urgency.

			regards, tom lane


[prev in list] [next in list] [prev in thread] [next in thread]