[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pgsql-bugs
Subject:    Re: BUG #17695: Failed Assert in logical replication snapbuild.
From:       Daniel Gustafsson <daniel () yesql ! se>
Date:       2023-03-27 11:49:01
Message-ID: DB7F9F38-11F6-4EA2-B414-5BD925A1FE25 () yesql ! se
[Download RAW message or body]

This thread has been idle for quite some time, and the test isn't running at
all, whereas there is more activity on the linked thread.  AFAICT from the
thread this issue is reproducible in HEAD so the test should be for master
right?  Should this be closed in favor of the other patch?

A quick glance at the failing test, assuming we want it for master:

+use TestLib;
+use PostgresNode;
This needs updating after b3b4d8e68ae which moved the test modules to a proper namespace.

+use DBI;
Not used in the test, and I can't see why it should be?

+use Test::More tests => 1;
We've moved away from explicit plans in favor of done_testing().

--
Daniel Gustafsson



[prev in list] [next in list] [prev in thread] [next in thread]