[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pgsql-bugs
Subject:    Re: [BUGS] creating a table with a serial column sets currval
From:       Tom Lane <tgl () sss ! pgh ! pa ! us>
Date:       2007-10-19 13:24:24
Message-ID: 10000.1192800264 () sss ! pgh ! pa ! us
[Download RAW message or body]

Kris Jurka <books@ejurka.com> writes:
> On Thu, 18 Oct 2007, Tom Lane wrote:
>> It's not that it gets put in the cache, it's that read_info gets called
>> (setting elm->increment).  I think we probably should clean this up by
>> creating a separate flag in that struct that explicitly says "currval is
>> valid", which would be set by nextval(), setval() (because historically
>> it's acted that way), and I guess ALTER SEQUENCE RESTART WITH (for
>> consistency with setval()).

> Personally I think setval should only set validCurrval and the last_value 
> if iscalled = true.  If is_called = false I think it should retain the 
> previous last_value if any until the next nextval call.

Hmm.  If we did that, then ALTER RESTART WITH (which always sets
iscalled false) shouldn't affect the flag either, which would likely
simplify matters a bit.  However, it would be a change in behavior,
so I'm not convinced we should back-patch 8.2 like that.

Any other opinions out there?

			regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
       subscribe-nomail command to majordomo@postgresql.org so that your
       message can get through to the mailing list cleanly
[prev in list] [next in list] [prev in thread] [next in thread]