[prev in list] [next in list] [prev in thread] [next in thread]
List: perl6-internals
Subject: Re: [svn:parrot] r36955 - trunk/src
From: jerry gay <jerry.gay () gmail ! com>
Date: 2009-02-24 15:29:30
Message-ID: 1d9a3f400902240729s523d64acxe0df081d5c0e1f60 () mail ! gmail ! com
[Download RAW message or body]
On Tue, Feb 24, 2009 at 01:53, <cotto@svn.parrot.org> wrote:
> Author: cotto
> Date: Tue Feb 24 09:53:44 2009
> New Revision: 36955
> URL: https://trac.parrot.org/parrot/changeset/36955
>
> Log:
> [codingstd] remove extra space after if
>
> Modified:
> trunk/src/packfile.c
>
> Modified: trunk/src/packfile.c
> ==============================================================================
> --- trunk/src/packfile.c Tue Feb 24 09:16:07 2009 (r36954)
> +++ trunk/src/packfile.c Tue Feb 24 09:53:44 2009 (r36955)
> @@ -2978,7 +2978,7 @@
> PMC_sub(new_sub)->seg = PMC_sub(old_sub)->seg;
>
> /* Vtable overrides and methods were already cloned, so don't reclone them. */
> - if (PMC_sub(new_sub)->vtable_index == -1
> + if (PMC_sub(new_sub)->vtable_index == -1
> && !(PMC_sub(old_sub)->comp_flags & SUB_COMP_FLAG_METHOD))
> Parrot_store_sub_in_namespace(interp, new_sub);
>
if i recall correctly, the coding standard specifies *at least* one
space, not *exactly* one. if this is the case, the test should be
modified to accept that. it's a minor nit, but the extra space helps
the parens on the next line line up visually. however, of greater
import to me is the magic number -1 in that line of code. i believe
we have a coding standard against those, but we haven't developed a
proper test. i'm curious as to how many violations we have, as i
think we've done a good job of eliminating them; i wonder if the job
could be completed this month.
~jerry
_______________________________________________
http://lists.parrot.org/mailman/listinfo/parrot-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic