[prev in list] [next in list] [prev in thread] [next in thread] 

List:       perl5-porters
Subject:    Re: [perl #133141] cwd_enoent.t fails on DragonFly BSD
From:       Sawyer X <xsawyerx () gmail ! com>
Date:       2018-04-30 20:53:43
Message-ID: 70fcf35d-82b9-f97b-9262-4ebde595a08c () gmail ! com
[Download RAW message or body]



On 04/30/2018 03:27 PM, Dave Mitchell wrote:
> On Tue, Apr 24, 2018 at 02:18:15PM -0600, Karl Williamson wrote:
>> On 04/24/2018 12:37 PM, James E Keenan via RT wrote:
>>> On Sun, 22 Apr 2018 22:07:52 GMT, me@xenu.pl wrote:
>>>> The patch is attached.
>>> Available for smoke-testing in:
>>> smoke-me/jkeenan/xenu/133141-dragonfly
>>>
>> I support adding skips to tests during the freeze which fix failing smokes.
>> The changes are isolated to the particular .t, and don't affect the
>> functioning of the actual interpreter.
>>
>> But I'm thinking that skips for OS bugs, like this, should have be written
>> so that they don't apply to any future version of the OS, if we have any
>> hope at all that the vendor will eventually fix it.  If the OS gets fixed,
>> the test will automatically happen again; if a new version of the OS is
>> released, and is still broken, we would have to update the test, but could
>> then prod the vendor that this is an issue.
> While agree in principle, this late in code freeze, I'm happy for that
> patch to applies as-is (i.e. skip those tests if $^O eq 'dragonfly',
> regardless of version).

Go for it.
[prev in list] [next in list] [prev in thread] [next in thread]