[prev in list] [next in list] [prev in thread] [next in thread] 

List:       perl5-porters
Subject:    [perl #130854] [PATCH] Class::Struct calls UNIVERSAL::isa as a function
From:       "Tony Cook via RT" <perlbug-followup () perl ! org>
Date:       2017-02-27 0:32:35
Message-ID: rt-4.0.24-1306-1488155555-1142.130854-15-0 () perl ! org
[Download RAW message or body]

On Sun, 26 Feb 2017 13:09:56 -0800, jkeenan wrote:
> On Fri, 24 Feb 2017 21:44:04 GMT, jkahrman@mathworks.com wrote:
> > This is a bug report for perl from jkahrman@mathworks.com,
> > generated with the help of perlbug 1.40 running under perl 5.20.2.
> > 
> > Class::Struct calls UNIVERSAL::isa as a function to check class
> > membership when
> > setting a data member that is defined as a class. Since it is called
> > as a
> > function, if the class has overriden the 'isa' method, it will not be
> > called.
> > 
> > This is painful when attempting to unit test classes whose data
> > members have
> > been generated by Class::Struct.
> > 
> 
> Thanks for the patch.  However, I see that you've drawn it against
> perl-5.20.2, which is no longer supported.
> 
> Would it be possible to re-draw the patch against perl 5 blead, e.g.,
> with git format-patch?
> 
> Since we're now in a pre-5.26.0-release code freeze, I'm going to mark
> this ticket to be reviewed for perl-5.27.1.

As you say it should be delayed until 5.27.

The patch itself, once the format is fixed (the before and after paths have different \
numbers of path prefixes to remove) applies cleanly to blead, so a format-patch patch \
will just add the author and comment (which is still useful).

Tony

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=130854


[prev in list] [next in list] [prev in thread] [next in thread]