[prev in list] [next in list] [prev in thread] [next in thread] 

List:       perl5-porters
Subject:    Re: Tie::ExtraHash tests
From:       David Cantrell <david () cantrell ! org ! uk>
Date:       2010-07-31 9:51:57
Message-ID: 20100731095156.GA8687 () bytemark ! barnyard ! co ! uk
[Download RAW message or body]

On Fri, Jul 30, 2010 at 11:23:12AM +0100, David Cantrell wrote:
> On Wed, Jul 28, 2010 at 10:20:43AM +0100, David Cantrell wrote:
> > On Tue, Jul 27, 2010 at 03:13:47PM +0200, Rafael Garcia-Suarez wrote:
> > > On 27 July 2010 15:06, David Cantrell <david@cantrell.org.uk> wrote:
> > > > Can someone tell me where the Tie::ExtraHash tests are?  I'm buggered if
> > > > I can find them.
> > > This module not being defined in its own file, it might have fallen
> > > through the cracks and was not listed here :
> > > http://perl-qa.hexten.net/wiki/index.php/Untested_Core_Modules
> > Right, I'll get on to that then.
> Attached.  However, wherever I put it in a freshly downloaded 5.13.3
> source tree I can't get it to run as part of 'make test'.  Presumably
> I'm missing some dark magic somewhere in the build jibber-jabber.

Adding it to MANIFEST fixed that (thanks to Jim Cromie for the
suggestion).  I've also added some stuff to Maintainers.pl and made a
trivial fix to t/porting/maintainers.t..

Diff attached.

-- 
David Cantrell | Bourgeois reactionary pig

  Longum iter est per praecepta, breve et efficax per exempla.

["extrahash-extras.diff" (text/plain)]

--- perl-5.13.3~/Porting/Maintainers.pl	2010-07-19 06:03:28.000000000 +0100
+++ perl-5.13.3/Porting/Maintainers.pl	2010-07-31 10:13:52.000000000 +0100
@@ -24,6 +24,7 @@
     'corion'	=> 'Max Maischein <corion@corion.net>',
     'craig'	=> 'Craig Berry <craigberry@mac.com>',
     'dankogai'	=> 'Dan Kogai <dankogai@cpan.org>',
+    'dcantrell'	=> 'David Cantrell <dcantrell@cpan.org>',
     'dconway'	=> 'Damian Conway <dconway@cpan.org>',
     'dland'	=> 'David Landgren <dland@cpan.org>',
     'dmanura'	=> 'David Manura <dmanura@cpan.org>',
@@ -1763,6 +1764,7 @@
 				lib/Thread.{pm,t}
 				lib/Tie/Array.pm
 				lib/Tie/Array/
+				lib/Tie/ExtraHash.t
 				lib/Tie/Handle.pm
 				lib/Tie/Handle/
 				lib/Tie/Hash.pm
--- perl-5.13.3~/MANIFEST	2010-07-20 08:22:12.000000000 +0100
+++ perl-5.13.3/MANIFEST	2010-07-31 10:29:08.000000000 +0100
@@ -3607,6 +3607,7 @@
 lib/Tie/Array/splice.t		Test for Tie::Array::SPLICE
 lib/Tie/Array/stdpush.t		Test for Tie::StdArray
 lib/Tie/Array/std.t		Test for Tie::StdArray
+lib/Tie/ExtraHash.t		Test for Tie::ExtraHash (in Tie/Hash.pm)
 lib/Tie/Handle.pm		Base class for tied handles
 lib/Tie/Handle/stdhandle_from_handle.t	Test for Tie::StdHandle/Handle backwards compat
 lib/Tie/Handle/stdhandle.t	Test for Tie::StdHandle
--- perl-5.13.3~/t/porting/maintainers.t	2010-07-09 03:08:05.000000000 +0100
+++ perl-5.13.3/t/porting/maintainers.t	2010-07-31 10:28:22.000000000 +0100
@@ -1,6 +1,6 @@
 #!./perl -w
 
-# Test that there are no missing Maintainers in Maintainers.PL 
+# Test that there are no missing Maintainers in Maintainers.pl
 
 BEGIN {
 	# This test script uses a slightly atypical invocation of the 'standard'


[prev in list] [next in list] [prev in thread] [next in thread]