[prev in list] [next in list] [prev in thread] [next in thread] 

List:       perl5-porters
Subject:    RE: [perl.git]  branch maint-5.12, updated. v5.12.1-54-ga6daf67
From:       "Jan Dubois" <jand () activestate ! com>
Date:       2010-07-29 22:24:45
Message-ID: 011a01cb2f6c$d921b730$8b652590$ () activestate ! com
[Download RAW message or body]

On Thu, 29 Jul 2010, Vincent Pit wrote:
> 
> In perl.git, the branch maint-5.12 has been updated
> 
> <http://perl5.git.perl.org/perl.git/commitdiff/a6daf678d40557c700ca05180ed943761fd5286a?hp=1840d88ef5f1c5cf1625ba946
>  52460ea16a48cd0>
> 
> - Log -----------------------------------------------------------------
> commit a6daf678d40557c700ca05180ed943761fd5286a
> Author: Vincent Pit <perl@profvince.com>
> Date:   Thu Jul 29 23:54:58 2010 +0200
> 
> croak_sv(xpt) isn't available in 5.12.x
> 
> So replace it by croak(SvPVX(xpt)), as we know that xpt has POK on.

The idiomatic replacement would be

    croak("%s", SvPVX(xpt));

unless you are absolutely sure that SvPVX(xpt) cannot contain any '%' characters.

Cheers,
-Jan


[prev in list] [next in list] [prev in thread] [next in thread]