[prev in list] [next in list] [prev in thread] [next in thread] 

List:       perl5-porters
Subject:    Re: remaining signedness issue in Encode 1.88
From:       "Craig A. Berry" <craigberry () mac ! com>
Date:       2003-02-27 21:22:56
[Download RAW message or body]

At 6:37 PM +0900 2/27/03, Dan Kogai wrote:
> On Thursday, Feb 27, 2003, at 16:56 Asia/Tokyo, Dan Kogai wrote:
> > On Wednesday, Feb 26, 2003, at 14:49 Asia/Tokyo, Craig A. Berry wrote:
> > > it seems like it would be a good idea to protect against that even if
> > > it's not supposed to happen.
> > 
> > I do agree with that.  The question is how...
> 
> Craig,
> 
> Would you try the patch below ?  Instead of typecasting I now made sure that slen \
> is never negative.  Already passed 'make test' here. 
> --- Encode.xs   2003/02/20 14:42:34     1.54
> +++ Encode.xs   2003/02/27 09:32:04

That compiles without warnings and passes all tests for me.  Thanks.

-- 
________________________________________
Craig A. Berry
mailto:craigberry@mac.com

"... getting out of a sonnet is much more
 difficult than getting in."
                 Brad Leithauser


[prev in list] [next in list] [prev in thread] [next in thread]