[prev in list] [next in list] [prev in thread] [next in thread] 

List:       perl5-changes
Subject:    [Perl/perl5] f8c577: PerlIOScalar_pushed: move SvUPGRADE to where it mi...
From:       Richard Leach via perl5-changes <perl5-changes () perl ! org>
Date:       2023-08-27 22:42:02
Message-ID: Perl/perl5/push/refs/heads/blead/b82b16-f8c577 () github ! com
[Download RAW message or body]

  Branch: refs/heads/blead
  Home:   https://github.com/Perl/perl5
  Commit: f8c57796889a55dbc338669517501dcae1eec73b
      https://github.com/Perl/perl5/commit/f8c57796889a55dbc338669517501dcae1eec73b
  Author: Richard Leach <richardleach@users.noreply.github.com>
  Date:   2023-08-27 (Sun, 27 Aug 2023)

  Changed paths:
    M perlio.c

  Log Message:
  -----------
  PerlIOScalar_pushed: move SvUPGRADE to where it might apply

`newSVpvs("")` returns an SV of type `SVt_PV`, therefore there's no
point in calling `SvUPGRADE(..., SVt_PV)` on it.

The other nearby code paths _might_ set an SV that needs upgrading
(I haven't looked into the logic), so the `SvUPGRADE` statement has
been moved inside the relevant branch rather than being removed.


[prev in list] [next in list] [prev in thread] [next in thread]