[prev in list] [next in list] [prev in thread] [next in thread] 

List:       perl5-changes
Subject:    [Perl/perl5] 82196d: test dist/ modules against various older perls in CI
From:       Tony Cook via perl5-changes <perl5-changes () perl ! org>
Date:       2022-08-31 1:07:52
Message-ID: Perl/perl5/push/refs/heads/blead/b885e4-445772 () github ! com
[Download RAW message or body]

  Branch: refs/heads/blead
  Home:   https://github.com/Perl/perl5
  Commit: 82196dc6c4b9e7e18c1e4e41754dfb94f21ff91c
      https://github.com/Perl/perl5/commit/82196dc6c4b9e7e18c1e4e41754dfb94f21ff91c
  Author: Tony Cook <tony@develop-help.com>
  Date:   2022-08-31 (Wed, 31 Aug 2022)

  Changed paths:
    M .github/workflows/testsuite.yml
    M MANIFEST
    M Porting/README.pod
    A Porting/test-dist-modules.pl

  Log Message:
  -----------
  test dist/ modules against various older perls in CI

This currently has one major limitation: the perl-testers images
aren't threaded and don't have threaded alternatives, so the threads,
threads-shared and Thread-Queue dists are effectively untested on the
older perls.

The perl-testers images have a large number of test modules and their
dependencies installed, which means we're testing against the latest
versions of those dependencies (such as parent.pm) rather than against
the version of that dependency that shipped with that perl.

I tried to use the official perl images, but these only include a
small number of recent perls.  The git repository includes DockerFiles
for the older versions, but these aren't published to Docker Hub.


  Commit: 0453e438a8f332257ce7c23aa57fefbd1bc747c2
      https://github.com/Perl/perl5/commit/0453e438a8f332257ce7c23aa57fefbd1bc747c2
  Author: Tony Cook <tony@develop-help.com>
  Date:   2022-08-31 (Wed, 31 Aug 2022)

  Changed paths:
    M dist/PathTools/t/cwd_enoent.t

  Log Message:
  -----------
  fix warning/error on 5.8 with ambiguous ?...? operator

Warning: Use of "defined" without parentheses is ambiguous at t/cwd_enoent.t line 32.
Search pattern not terminated at t/cwd_enoent.t line 32.


  Commit: 3b5ec3ec745c3978b2a60a12f13c860a52b1e3cd
      https://github.com/Perl/perl5/commit/3b5ec3ec745c3978b2a60a12f13c860a52b1e3cd
  Author: Tony Cook <tony@develop-help.com>
  Date:   2022-08-31 (Wed, 31 Aug 2022)

  Changed paths:
    M dist/Safe/t/safeload.t

  Log Message:
  -----------
  version loads warnings, which loads Carp in older versions

Carp calls rand().


  Commit: 1049a8cc76dcf4d16c21953ff1a47c981058faff
      https://github.com/Perl/perl5/commit/1049a8cc76dcf4d16c21953ff1a47c981058faff
  Author: Tony Cook <tony@develop-help.com>
  Date:   2022-08-31 (Wed, 31 Aug 2022)

  Changed paths:
    M dist/SelfLoader/t/03taint.t

  Log Message:
  -----------
  SelfLoader: /r isn't available for old perls


  Commit: a635e7229b4739a8f572bc3fcfea1e931f4068e7
      https://github.com/Perl/perl5/commit/a635e7229b4739a8f572bc3fcfea1e931f4068e7
  Author: Tony Cook <tony@develop-help.com>
  Date:   2022-08-31 (Wed, 31 Aug 2022)

  Changed paths:
    M dist/XSLoader/t/XSLoader.t

  Log Message:
  -----------
  XSLoader.t: fix local skip() implementation

It failed to output:

  ok N # skip ....

lines for each skipped test, which meant the tests output didn't match
the test count in the plan.


  Commit: 445772e597b9e104266dc7ec971e260c3f298982
      https://github.com/Perl/perl5/commit/445772e597b9e104266dc7ec971e260c3f298982
  Author: Tony Cook <tony@develop-help.com>
  Date:   2022-08-31 (Wed, 31 Aug 2022)

  Changed paths:
    M Porting/test-dist-modules.pl

  Log Message:
  -----------
  apply several of the suggestions from @bram-perl

- add an actual error message with `$!` for an opendir failure
- document why Devel-PPPort is treated specially when filtering
  the readdir() results
- change each system() call to list form
- add some explanation to write_testpl()

Also:
- expand die messages for system() failures


Compare: https://github.com/Perl/perl5/compare/b885e42dc207...445772e597b9
[prev in list] [next in list] [prev in thread] [next in thread]