[prev in list] [next in list] [prev in thread] [next in thread] 

List:       perl5-changes
Subject:    [perl.git]  branch toddr/hek_flags, created. v5.25.6-49-g8230936
From:       Yves Orton <demerphq () gmail ! com>
Date:       2016-10-23 8:12:28
Message-ID: E1byDtM-0008Nk-3M () camel-001 ! ams6 ! corp ! booking ! com
[Download RAW message or body]

In perl.git, the branch toddr/hek_flags has been created

<http://perl5.git.perl.org/perl.git/commitdiff/82309362a56bd9b3ed4e112170598ff1d7591ec0?hp=0000000000000000000000000000000000000000>


        at  82309362a56bd9b3ed4e112170598ff1d7591ec0 (commit)

- Log -----------------------------------------------------------------
commit 82309362a56bd9b3ed4e112170598ff1d7591ec0
Author: Todd Rinaldo <toddr@cpan.org>
Date:   Thu Oct 13 22:38:31 2016 -0500

    hv.h: rework HEK_FLAGS to a proper member in struct hek
    
    Move the store of HEK_FLAGS off the end of the allocated
    hek_key into the hek struct, simplifying access and providing
    clarity to the code.
    
    What is not clear is why Nicholas or perhaps Jarkko did
    not do this themselves. We use similar tricks elsewhere,
    so perhaps it was just continuing a tradition...
    
    One thought is that we often have do strcmp/memeq on these
    strings, and having their start be aligned might improve
    performance, wheras this patch changes them to be unaligned.
    If so perhaps we should just make flags a U32 and let the
    HEK's be larger. They are shared in PL_strtab, and are
    probably often sitting in malloc blocks that are sufficiently
    large enough that making them bigger would make no practical
    difference. (All of this is worth checking.)
    
    [with edits by Yves Orton]
-----------------------------------------------------------------------

--
Perl5 Master Repository


[prev in list] [next in list] [prev in thread] [next in thread]