[prev in list] [next in list] [prev in thread] [next in thread] 

List:       perl5-changes
Subject:    Change 31664: [rt.cpan.org #28537] PATCH for croak.t test failure
From:       Abhijit Menon-Sen <ams () wiw ! org>
Date:       2007-07-29 14:00:03
Message-ID: 20070729140003.16DC22168C0 () mx ! activestate ! com
[Download RAW message or body]

Change 31664 by ams@penne on 2007/07/29 13:45:31

	Subject: [rt.cpan.org #28537] PATCH for croak.t test failure 
	From: Slaven_Rezic via RT <bug-Storable@rt.cpan.org>
	Date: Sun, 29 Jul 2007 05:10:46 -0400
	Message-Id: <rt-3.6.HEAD-28249-1185700244-992.28537-4-0@rt.cpan.org>
	
	"The attached patch solves a possible failure in the croak.t
	test. It seems that in some version Config.pm pre-loads Carp.pm,
	causing the test to fail. The patch just makes sure that
	Config.pm is only loaded when building Storable within core
	perl."

Affected files ...

... //depot/perl/ext/Storable/t/croak.t#3 edit

Differences ...

==== //depot/perl/ext/Storable/t/croak.t#3 (text) ====
Index: perl/ext/Storable/t/croak.t
--- perl/ext/Storable/t/croak.t#2~16664~	2002-05-17 14:39:37.000000000 -0700
+++ perl/ext/Storable/t/croak.t	2007-07-29 06:45:31.000000000 -0700
@@ -10,10 +10,13 @@
 	chdir('t') if -d 't';
 	@INC = ('.', '../lib');
     }
-    require Config; import Config;
-    if ($ENV{PERL_CORE} and $Config{'extensions'} !~ /\bStorable\b/) {
-        print "1..0 # Skip: Storable was not built\n";
-        exit 0;
+    if ($ENV{PERL_CORE}) {
+	require Config; import Config;
+	%Config=%Config if 0; # cease -w
+	if ($Config{'extensions'} !~ /\bStorable\b/) {
+	    print "1..0 # Skip: Storable was not built\n";
+	    exit 0;
+	}
     }
 }
 
End of Patch.
[prev in list] [next in list] [prev in thread] [next in thread]