[prev in list] [next in list] [prev in thread] [next in thread] 

List:       perl-module-build
Subject:    Re: [rt.cpan.org #53478] Diffs with ActiveState HTML generation and
From:       David Golden <dagolden () cpan ! org>
Date:       2010-04-14 17:21:08
Message-ID: x2z5d4beb41004141021qc9ed1ea2s5ca3096c4f9b3a60 () mail ! gmail ! com
[Download RAW message or body]

On Wed, Apr 14, 2010 at 2:25 AM, Klaus Eichner via RT
<bug-Module-Build@rt.cpan.org> wrote:
> Now that Perl 5.12 is out,
> can we discuss the changes to Module::Build::Base (and a new module
> ActivePerl::PPM::InstallHist) ? as per the attachment -- two files
> 'Base.36032.pm' and 'InstallHist.00100.pm' -- in my message from 10 Feb
> 2010.

We can try.  Since your patch, Module::Build has migrated to git and
is being hosted at github.

   http://github.com/dagolden/module-build/

I have created a branch 'rt/53478' with your patch:

    http://github.com/dagolden/module-build/tree/rt/53478

It fails t/ppm.t because that test expects HTML files and the patch
stops them from being produced.  (Intentionally).  I'm not sure if
that is the right thing, since it may impact non-ActiveState users of
PPM.

Now that we have git for easy branching, I encourage more refinements
for that branch including getting all tests to a passing state.

If no one on the M::B mailing list objects to PPM no longer having
HTML generated for them, or has an alternate solution that gets
consensus, I'd be happy to merge the branch into the main line.

Regards,
David
[prev in list] [next in list] [prev in thread] [next in thread]