[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pear-dev
Subject:    Re: [PEAR-DEV] A new packages
From:       Gemor Roj <wapinet () gmail ! com>
Date:       2012-11-11 18:39:55
Message-ID: CABmJSrzV=2xMR2QRMhRkJkANG9zfYwtniQ8RH0nyowG=5O_D6w () mail ! gmail ! com
[Download RAW message or body]


Thanks for reminding me about the tests.
https://github.com/Gemorroj/Archive_7z/blob/master/Archive/7z.php#L22 path
can override the default
https://github.com/Gemorroj/Archive_7z/blob/master/Archive/7z.php#L83
As for PEAR2. For now I can not afford to raise dependency PHP>=5.3.
Packages will be used on a server with PHP>=5.2.


2012/11/11 till <klimpong@gmail.com>

> Hey,
>
> On Sunday, November 11, 2012 at 6:45 PM, Gemor Roj wrote:
>
> > Hello.
> > I would suggest two new packages -
> https://github.com/Gemorroj/Archive_7z
> > and https://github.com/Gemorroj/MP3_Id3.
> > Archive_7z allows you to work with 7z archives (currently, only reading
> > and unpacking) and requires a command-line utility 7z.
> > MP3_Id3 designed to read and write Id3 tags. Depending packages MP3_Id
> and
> > MP3_IDv2. Unlike MP3_Id and MP3_IDv2, MP3_Id3 combines work with tags in
> a
> > format Idv1 and Idv2. And also has a simple and intuitive interface than
> > MP3_IDv2.
>
> First off — impressive work. :)
> >
> > I would like to know the opinion of the developers, should I continue to
> > develop applications as PEAR packages? What should I look for in the code
> > (except for documentation)?
>
> The major thing I would suggest you work on some unit tests for your code.
> They can also serve as documentation until you get around to it.
>
> Overall, code looks really good though (just glancing over it). There are
> some minor details, e.g. this:
> https://github.com/Gemorroj/Archive_7z/blob/master/Archive/7z.php#L22
>
> So this is fine for 'most' cases, but I bet there are systems out there
> where that path wouldn't work. So in that respect, it seems like the best
> option would be a class variable which people can override using a setCli()
> or similar method.
>
> But anyway — this is just me glancing over the code.
>
> The other thing is, I would suggest to take this to PHP 5.3 (e.g. for
> namespaces, autoload, etc.) and into pear2[1] if you wanted to propose your
> code to PEAR. :)
> >
> > P.S. I apologize for the bad English. This is my problem.
> You're doing great!
>
> Till
>
> [1]: http://pear2.php.net/
>
>
>


[prev in list] [next in list] [prev in thread] [next in thread]