[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pear-cvs
Subject:    Re: [PEAR-CVS] cvs: pear /XML_Serializer Serializer.php
From:       "Daniel O'Connor" <daniel.oconnor () gmail ! com>
Date:       2009-05-24 3:18:04
Message-ID: 106cc1200905232006w6c02aaddm8c526c0e0d3d7985 () mail ! gmail ! com
[Download RAW message or body]


On Sun, May 24, 2009 at 4:32 AM, Hannes Magnusson <bjori@php.net> wrote:

> On Sat, May 23, 2009 at 19:43, Daniel O'Connor <clockwerx@php.net> wrote:
> > clockwerx               Sat May 23 17:43:35 2009 UTC
> >
> >  Modified files:
> >    /pear/XML_Serializer        Serializer.php
> >  Log:
> >  Bug #16072 - PHP4 regression
>
> What happened to "gophp5.org"?
>

http://pear.php.net/bugs/bug.php?id=16072

If a package was PHP 4 compatible when it was born it should still function
for them.
If this was a PHP 5 package from the start, then sure.

>             // can be used both for attributes and content)
> > -            foreach ($tag['attributes'] as $k => &$v) {
> > +            foreach ($tag['attributes'] as $k => $v) {
> >                 $v = XML_Util::replaceEntities($v,
> >                     $this->options[XML_SERIALIZER_OPTION_ENTITIES]);
> >             }
>

Was resolved in the next commit :)


[prev in list] [next in list] [prev in thread] [next in thread]