[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pear-cvs
Subject:    Re: [PEAR-CVS] cvs: pearweb /public_html release-upload.php
From:       Markus Fischer <mfischer () guru ! josefine ! at>
Date:       2001-12-29 11:27:50
[Download RAW message or body]

On Sat, Dec 29, 2001 at 10:26:59AM -0000, Martin Jansen wrote : 
> /pearweb/public_html	release-upload.php 
> Log:
> * Add some checks to prevent warnings.

    Why not use something like

        foreach (array('summary', 'description', 'release_state', 'release_date', \
'releases_notes') as $key) {  if (!isset($info[$key]))
                $info[$key] = 'n/a';
        }

    before the print statements

> -	print "<tr><th align=\"right\">Summary:</th><td>$info[summary]</td></tr>\n";
> -	print "<tr><th align=\"right\">Description:</th><td>".nl2br($info['description'])."</td></tr>\n";
>                 
> -	print "<tr><th align=\"right\">Release \
>                 State:</th><td>$info[release_state]</td></tr>\n";
> -	print "<tr><th align=\"right\">Release \
>                 Date:</th><td>$info[release_date]</td></tr>\n";
> -	print "<tr><th align=\"right\">Release \
> Notes:</th><td>".nl2br($info['release_notes'])."</td></tr>\n";

    It will be less nastier if the html has to be changed (oh,
    and btw you missed the quotes when accessing the values).

-- 
Please always Cc to me when replying to me on the lists.

-- 
PEAR CVS Mailing List (http://pear.php.net/)
To unsubscribe, e-mail: pear-cvs-unsubscribe@lists.php.net
For additional commands, e-mail: pear-cvs-help@lists.php.net
To contact the list administrators, e-mail: php-list-admin@lists.php.net


[prev in list] [next in list] [prev in thread] [next in thread]