[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pcc-list
Subject:    Re: [Pcc] optim.c
From:       Peter Kuschnerus <peter.kuschnerus () gmx ! de>
Date:       2017-05-17 11:51:26
Message-ID: 0e972912-a0b0-cc39-a6e4-6acc19dcbf37 () gmx ! de
[Download RAW message or body]

Hallo

I tested selfprepared test to check each mew feature
to satisfy myself that the code does as expected.
But I agree that more tests should be done.

Regards
Peter Kuschnerus


On 16.05.2017 20:28, Tim Kelly wrote:
> Hi Peter,
> I an not a pcc developer, but I asked Ragge if he had looked at your
> code.  He said no, and he is very behind with his work, as he was quite
> sick in April.  It may be a while, but he was not concerned about side
> effects of discarding subtrees, so that would be a positive.
>
> There are some tests in pcc-tests.  Have you run them against your new
> code?
>
> tim
>
> Peter Kuschnerus wrote:
>> Hello
>>
>> I did review the code of optim.c in pass1.
>> And I found that there are several obvious possible optimisations
>> that are omitted.
>> Most of these optimisations would cause to discard a subtree.
>> Discarding subtrees is never done in this module.
>> Discarding subtrees has the problem with possible side effects,
>> which must be handeled.
>> Now I implemented several additional optimisations.
>> To handle possible side effects, I used the method of inserting
>> a COMOP-operation, and let the cleanup be done later in pass2.
>>
>> I tested an updated version of optim.c.
>> And it seems to work well.
>>
>> Now I like to present this version.
>> As I am not a member of this team,
>> I send this patch for further review and test.
>> This patch was created by
>> "diff -u optim.c optim.c.new >optim.c.patch"
>> It can be applied by "patch optim.c optim.c.patch"
>>
>> This patch is attached to this mail.
>>
>>
>> Regards
>> Peter Kuschnerus
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Pcc mailing list
>> Pcc@lists.ludd.ltu.se
>> https://lists.ludd.ltu.se/cgi-bin/mailman/listinfo/pcc
>
_______________________________________________
Pcc mailing list
Pcc@lists.ludd.ltu.se
https://lists.ludd.ltu.se/cgi-bin/mailman/listinfo/pcc
[prev in list] [next in list] [prev in thread] [next in thread]