[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pcc-list
Subject:    Re: [Pcc] [PATCH 5/9] CC driver: handle empty lists explicitely
From:       Iain Hibbert <plunky () ogmig ! net>
Date:       2014-12-18 21:44:02
Message-ID: alpine.NEB.2.00.1412182142350.3567 () galant ! ogmig ! net
[Download RAW message or body]

On Thu, 18 Dec 2014, Iain Hibbert wrote:

> On Wed, 17 Dec 2014, Antoine Leca wrote:
>
> > >> @@ -1882,9 +1886,9 @@ setup_ld_flags(void)
> > >>  		}
> > >>  		strap(&middle_linker_flags, &crtdirs, b, 'p');
> > >>  		strap(&late_linker_flags, &crtdirs, e, 'a');
> > >> -		if (CRTI[0])
> > >> +		if (CRTI && CRTI[0])
> > >>  			strap(&middle_linker_flags, &crtdirs, CRTI, 'p');
> > >> -		if (CRTN[0])
> > >> +		if (CRTN && CRTN[0])
> > >>  			strap(&late_linker_flags, &crtdirs, CRTN, 'a');
> > >
> > > also, I think if you don't want CRTI and CRTN then just define them as ""?
> >
> > Certainly something I could do, just a matter of conventions: it just
> > happened to map nicely with the behaviour of strap() and the values used
> > for CRT0 or CRT{BEGIN,END}* and was the way the bsd or darwin
> > configurations was programmed; but I just noticed that OpenBSD was
> > upgraded (more recently) accordingly to your point; so I'll adjust.
>
> Hm, I see what you mean though. I don't know why it needs to be like
> that.. if CRTI or CRTN is 0 (invalid) or "..." (valid) then strap() can be
> called directly without the test, I think?

I made them consistent with the others, and changed the
midnightbsd/sunos/nextstep ccconfig.h files to hopefully suit the new
scheme

iain
_______________________________________________
Pcc mailing list
Pcc@lists.ludd.ltu.se
https://lists.ludd.ltu.se/cgi-bin/mailman/listinfo/pcc
[prev in list] [next in list] [prev in thread] [next in thread]