[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pcc-list
Subject:    test -z "<string>" || mkdir
From:       Iain Hibbert <plunky () rya-online ! net>
Date:       2012-08-30 10:43:07
Message-ID: alpine.NEB.2.00.1208301132340.21255 () galant ! ukfsn ! org
[Download RAW message or body]

Hi

was looking at (various) Makefile.in; this construct in the "install"
target

  test -z "$(DESTDIR)$(bindir)" || mkdir -p "$(DESTDIR)$(bindir)"

seems wrong.. surely it should just be

  test -z "$(bindir)" || mkdir -p "$(DESTDIR)$(bindir)"

?

similarly with

  test -z "$(DESTDIR)$(mandir)/man1" || mkdir -p "$(DESTDIR)$(mandir)/man1"

since that test can never be false anyway.. what are we testing for?

regards,
iain
[prev in list] [next in list] [prev in thread] [next in thread]