[prev in list] [next in list] [prev in thread] [next in thread] 

List:       password-store
Subject:    Re: [PATCH] git: Do not end commit titles with dots
From:       Sitaram Chamarty <sitaramc () gmail ! com>
Date:       2019-04-01 1:43:26
Message-ID: 6027fb5b-cf41-c06f-c7b9-e7ac6059c3b5 () gmail ! com
[Download RAW message or body]

Somewhat ironically, considering the topic under discussion, I looked
only at the subject line and responded, without realising that this is
about a single sentence-ending period, not literally "dots" (plural).

I blame Monday morning blues (it's Monday morning here in India).

Apologies for the noise.

But back on topic, I support this patch, for what it is worth.

On 01/04/2019 06.50, Sitaram Chamarty wrote:
> On 01/04/2019 04.02, Artur Juraszek wrote:
>> Umm, does someone have any more thoughts on this? ;]
>>
>> On 3/23/19 3:19 PM, HacKan wrote:
>>> It's a nice detail, and doesn't hurt. +1
>>>
>>> On March 23, 2019 7:51:30 AM GMT-03:00, Artur Juraszek
>>> <artur@juraszek.xyz> wrote:
>>>
>>>     So, as far as I know treating the first line of commit messages
>>>     as _title_ and what follows as _body_ is a generally followed git practice,
>>>     and titles usually don't end with dots.
> 
> I've always used a trailing "..." to mean "you *should* read the rest of
> the commit message to get the proper context".
> 
> A title without dots means the rest of the commit message is merely
> additional explanation, may be interesting/useful but not *required* to
> be read in order to get a feel for what is going on in that commit.
> 
> Helps me when I am looking at a "git log --oneline" (or equivalent)
> 

_______________________________________________
Password-Store mailing list
Password-Store@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/password-store
[prev in list] [next in list] [prev in thread] [next in thread]