[prev in list] [next in list] [prev in thread] [next in thread] 

List:       password-store
Subject:    Re: [PATCH] add possibility to use git in a sub-folder for multi repo
From:       David A. <listmail () cox ! net>
Date:       2017-04-12 3:59:52
Message-ID: cm8rect9kqv6rab8qn0k27f4bajncep8jg () 4ax ! com
[Download RAW message or body]

On Tue, 11 Apr 2017 16:51:12 +0200, Philippe BEAUMONT
<philippe.beaumont@nfrance.com> wrote:

>Le 10/04/2017 =E0 19:39, Jason A. Donenfeld a =E9crit :
>
>> I like this idea, but the implementation is bad. Please use getopt
>> just like every other subcommand that takes arguments.
>
>I have rewrite with getopt and my test are correct. If you have any =

>other sugestion, please tell me to adapt the patch.

Wouldn't it be a cleaner solution to have pass issue ALL git commands
with CWD as the .password-store directory rather than using the
GIT_DIR and GIT_WORK_TREE variables to inform git where the repo is?
Then you could pass -C directly to git along with everything else on
the command line and it will work *as documented* on the git manpage.
You wouldn't have to parse and override an existing git option, and
both pass and git would work as currently documented without any
changes.

_______________________________________________
Password-Store mailing list
Password-Store@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/password-store
[prev in list] [next in list] [prev in thread] [next in thread]