From owncloud Tue Jun 12 17:24:27 2012 From: Sam Tuke Date: Tue, 12 Jun 2012 17:24:27 +0000 To: owncloud Subject: Re: [Owncloud] Making internal methods public for unit testing Message-Id: <1359250.Z8iFZSgJQX () sam-desktop> X-MARC-Message: https://marc.info/?l=owncloud&m=133952211411025 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3203746709206226737==" --===============3203746709206226737== Content-Type: multipart/signed; boundary="nextPart2275702.dIYF3RvlmJ"; micalg="pgp-sha256"; protocol="application/pgp-signature" Content-Transfer-Encoding: quoted-printable --nextPart2275702.dIYF3RvlmJ Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" On Monday 04 June 2012 12:53:02 Frank Karlitschek wrote: > > What are you testing, if it is the core, why not use the core OC_ c= lasses? I'm testing the files_versions app. In order to test any functionality = that=20 interacts with users, a dummy backend for the User class must be loaded= . > Same question from me. I don=B4t think we should make our public API = bigger > than needed only because we want to use unit tests. If we want apps to have unit tests, then any part of OC which must be a= ccessed=20 for the writing of tests should be in the public namespace. It seems to= me=20 that OCP\User class is just as public as any other class that needs acc= ess for=20 the testing of an app. Best, Sam. --nextPart2275702.dIYF3RvlmJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) iF4EABEIAAYFAk/Xe0sACgkQ1bR1Itj7YQVzCQEApNTg3mKRNTetDyVDKr6kE6q3 IyYboHIuYoI1u6EEgAgA/3XEmHX2yWUhcuq1+4/wbSDcTyGJcIVdHasj6zpQJemh =7s4i -----END PGP SIGNATURE----- --nextPart2275702.dIYF3RvlmJ-- --===============3203746709206226737== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Owncloud mailing list Owncloud@kde.org https://mail.kde.org/mailman/listinfo/owncloud --===============3203746709206226737==--