[prev in list] [next in list] [prev in thread] [next in thread] 

List:       otr-dev
Subject:    [OTR-dev] otrl_message_sending to recipient in finished state
From:       Martin Milata <b42-ml () srck ! net>
Date:       2014-04-02 15:36:36
Message-ID: 20140402153636.GA24650 () srck ! net
[Download RAW message or body]

When calling otrl_message_sending(..., OTRL_FRAGMENT_SEND_ALL, ...) to
recipient that is in finished state, the inject_message callback is
called with an empty string. The empty string is also returned in the
messagep pointer. (message.c:423 and on)

This seems like a bug to me. Returning "" in messagep can be interpreted
as 'libotr consumed the message, do not send anything' by the caller,
but injecting it as well seems wrong.

What do you think? I'll follow with a proposed patch.

Thanks,
Martin
_______________________________________________
OTR-dev mailing list
OTR-dev@lists.cypherpunks.ca
http://lists.cypherpunks.ca/mailman/listinfo/otr-dev
[prev in list] [next in list] [prev in thread] [next in thread]