[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ossec-dev
Subject:    [ossec-dev] Re: ossec-dbd
From:       lasbushus () googlemail ! com
Date:       2013-02-26 9:59:45
Message-ID: 6b208754-8435-4ef7-8034-f4e0e4d3154a () googlegroups ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hello,

I did take another look at the alert.c with a colleague of mine.
I was a bit generous at one of the lines, as it turns out.
Attached you will find my patch-file.

About the second patch, i've sent.
After I took another look at the sourcecode, I think i understand now why 
the checksums for instance are not in the db-logmessage anymore, so it's 
not a necessary patch.
It was just a bit confusing to see no more checksums in the db-log, after 
the ossec-update (a hint in the changelog would have been nice however, at 
least I didn't see it).

Best regards,
Robert

-- 

--- 
You received this message because you are subscribed to the Google Groups "ossec-dev" \
group. To unsubscribe from this group and stop receiving emails from it, send an \
email to ossec-dev+unsubscribe@googlegroups.com. For more options, visit \
https://groups.google.com/groups/opt_out.


[Attachment #5 (text/html)]

Hello,<br><br>I did take another look at the alert.c with a colleague of mine.<br>I \
was a bit generous at one of the lines, as it turns out.<br>Attached you will find my \
patch-file.<br><br>About the second patch, i've sent.<br>After I took another look at \
the sourcecode, I think i understand now why the checksums for instance are not in \
the db-logmessage anymore, so it's not a necessary patch.<br>It was just a bit \
confusing to see no more checksums in the db-log, after the ossec-update (a hint in \
the changelog would have been nice however, at least I didn't see it).<br><br>Best \
regards,<br>Robert<br>

<p></p>

-- <br />
&nbsp;<br />
--- <br />
You received this message because you are subscribed to the Google Groups \
&quot;ossec-dev&quot; group.<br /> To unsubscribe from this group and stop receiving \
emails from it, send an email to ossec-dev+unsubscribe@googlegroups.com.<br /> For \
more options, visit <a \
href="https://groups.google.com/groups/opt_out">https://groups.google.com/groups/opt_out</a>.<br \
/> &nbsp;<br />
&nbsp;<br />

------=_Part_54_21951631.1361872785721--


["ossec-dbd-length.patch" (text/x-diff)]

--- ossec-hids-2.7-orig/src/os_dbd/alert.c	2013-02-19 10:49:31.153036603 +0100
+++ ossec-hids-2.7/src/os_dbd/alert.c	2013-02-19 11:27:32.993036688 +0100
@@ -191,10 +191,10 @@
         long len = strlen(al_data->log[i]);
         char templog[len+2];
         if (al_data->log[i+1]) {
-            snprintf(templog, len, "%s\n", al_data->log[i]);
+            snprintf(templog, len+2, "%s\n", al_data->log[i]);
         }
         else {
-            snprintf(templog, len, "%s", al_data->log[i]);
+            snprintf(templog, len+1, "%s", al_data->log[i]);
         }
         fulllog = os_LoadString(fulllog, templog);
 //      fulllog = os_LoadString(fulllog, al_data->log[i]);


[prev in list] [next in list] [prev in thread] [next in thread]