[prev in list] [next in list] [prev in thread] [next in thread] 

List:       oss-security
Subject:    [oss-security] GraphicsMagick 1.3.32 security fixes, plus one of special mention
From:       Bob Friesenhahn <bfriesen () simple ! dallas ! tx ! us>
Date:       2019-06-15 20:17:22
Message-ID: alpine.GSO.2.20.1906151501090.1813 () freddy ! simplesystems ! org
[Download RAW message or body]

GraphicsMagick 1.3.32 is now released, fixing another 52 additional 
issues detected by oss-fuzz.

Of special mention is a bug reported to us by "Battle Furry" via our 
security mail alias.  This bug (was considered to be a "feature") 
allows including file text as rendered text on a graphic image, or as 
text hidden in metadata, by using a file refered to with '@filename' 
syntax where text to be rendered normally appears.  This issue was 
inherited from ImageMagick 5.5.2 and it even appears in ImageMagick 
4.2.9.

It has been determined that the SVG and WMF formats may be used to 
supply this '@filename' syntax, resulting in rendered text on a 
graphic image, or as text hidden in metadata (e.g. the image comment). 
Furthermore, it may be that other applications and web sites accept 
text to be rendered on behalf of users and that this issue could allow 
untrusted users to receive content considered to be secure and private 
(e.g. private keys or passwords).

A small patch to fix this issue is attached.  Any distribution of 
GraphicsMagick needs this patch if it is not possible to upgrade to 
the latest release.

Bob
-- 
Bob Friesenhahn
bfriesen@simple.dallas.tx.us, http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/
Public Key,     http://www.simplesystems.org/users/bfriesen/public-key.txt
["16037.patch" (text/plain)]

diff -r 1321ce2957ab -r f780c290b4ab magick/utility.c
--- a/magick/utility.c	Mon Jun 03 08:24:59 2019 -0500
+++ b/magick/utility.c	Thu Jun 06 08:41:00 2019 -0500
@@ -5934,16 +5934,6 @@
     return((char *) NULL);
   text=(char *) formatted_text;
   /*
-    If text starts with '@' then try to replace it with the content of
-    the file name which follows.
-  */
-  if ((*text == '@') && IsAccessible(text+1))
-    {
-      text=(char *) FileToBlob(text+1,&length,&image->exception);
-      if (text == (char *) NULL)
-        return((char *) NULL);
-    }
-  /*
     Translate any embedded format characters.
   */
   length=strlen(text)+MaxTextExtent;


[prev in list] [next in list] [prev in thread] [next in thread]