[prev in list] [next in list] [prev in thread] [next in thread] 

List:       osiris-devel
Subject:    [osiris-devel] Short comment to last patch
From:       "Alexei Roudnev" <Alexei_Roudnev () exigengroup ! com>
Date:       2003-12-23 23:07:18
Message-ID: 032101c3c9a9$8303b4a0$870ea8c0 () exigengroup ! com
[Download RAW message or body]

In last patch (to fix win2k problem and improve cli), I forget to remove
'ddd' from file_filter.c, which I used to ensure which parts are compiled on
Win2K. Just remove 'ddd' from line 52.


----- Original Message ----- 
From: "Brian Wotring" <brian@shmoo.com>
To: "Osiris Developers" <osiris-devel@lists.shmoo.com>
Sent: Thursday, November 27, 2003 5:23 PM
Subject: Re: [osiris-devel] Last napshot


>
> This is not the best solution, but I don't want to modify the
> management console before the release if I don't have to.
>
> ===================================================================
> RCS file: /home/cvs/projects/osiris/src/cli/osiris.c,v
> retrieving revision 1.236
> diff -r1.236 osiris.c
> 2292a2293,2299
>  >     /* if this was a shared config, we need to keep it a shared
> config. */
>  >
>  >     if( !current_host_has_config_with_name( ctl_context.buffer ) )
>  >     {
>  >         memset( ctl_context.host, 0, sizeof( ctl_context.host ) );
>  >     }
>  >
> 5523a5531,5582
>  >
>  > osi_bool current_host_has_config_with_name( const char *name )
>  > {
>  >     int config_count = 0;
>  >     osi_bool found = FALSE;
>  >
>  >     OSI_CONFIG_BRIEF *config_brief = NULL;
>  >     osi_list configs = NULL;
>  >
>  >     if( name == NULL )
>  >     {
>  >         goto exit_gracefully;
>  >     }
>  >
>  >     configs = ctl_get_config_brief_list( &ctl_context );
>  >
>  >     if( configs == NULL )
>  >     {
>  >         goto exit_gracefully;
>  >     }
>  >
>  >     config_count = list_get_size( configs );
>  >
>  >     if( config_count > 0 )
>  >     {
>  >         osi_list head = list_get_first_node( configs );
>  >
>  >         while( head )
>  >         {
>  >             if( ( config_brief = (OSI_CONFIG_BRIEF *)head->data ) !=
> NULL )
>  >             {
>  >                 if( strcmp( config_brief->name, name ) == 0 )
>  >                 {
>  >                     found = TRUE;
>  >                     break;
>  >                 }
>  >             }
>  >
>  >             head = list_get_next_node( head );
>  >         }
>  >     }
>  >
>  > exit_gracefully:
>  >
>  >     if( configs )
>  >     {
>  >         list_destroy_with_function( configs, (void (*)(void
> *))&osi_free );
>  >     }
>  >
>  >     return found;
>  > }
>  >
>
>
> On Nov 26, 2003, at 9:33 PM, Alexei_Roudnev wrote:
>
> >
> > I tested last version (from cvs, 11/26/2003, 7 pm PST time).
> >
> > Win2K      build OK
> > Solaris 2.7 build OK
> > Saving of the 'global' configurations in 'empty host' context - OK.
> >
> > But... there is one problem, which will be able to make a life a
> > nightmare:
> >
> > Run osiris
> >
> >
> >   host HOST-NAME
> >   edit GLOBAL-CONFIG
> >
> > as a result, this _GLOBAL_ config became a LOCAL one (duplicating
> > config
> > name).
> >
> > I know, why it happen (just as I was saying, 'read' search for the
> > file, but
> > 'save' works in 'host' context and so save it into the host directory;
> > see
> > my comments about naming), but it will cause a tremendows number of
> > errors.
> > System shoul dnot replicate global config as a local _quetly_.
> >
> >
> > I think that this should be fixed before release.
> >
> > Alex
> >
> >
> >
> > _______________________________________________
> > osiris-devel mailing list
> > osiris-devel@lists.shmoo.com
> > https://lists.shmoo.com/mailman/listinfo/osiris-devel
> >
> >
> --
>      Brian Wotring ( brian@shmoo.com )
>      PGP KeyID: 0x9674763D
>
> _______________________________________________
> osiris-devel mailing list
> osiris-devel@lists.shmoo.com
> https://lists.shmoo.com/mailman/listinfo/osiris-devel
>


[prev in list] [next in list] [prev in thread] [next in thread]