[prev in list] [next in list] [prev in thread] [next in thread] 

List:       orocos-users
Subject:    [Orocos-users] rttlua crash under xenomai.
From:       markus.klotzbuecher () mech ! kuleuven ! be (Markus Klotzbuecher)
Date:       2012-11-21 10:26:06
Message-ID: 20121121102606.GA15154 () PMA-10-048
[Download RAW message or body]

Hi Konrad,

On Wed, Nov 21, 2012 at 10:21:59AM +0100, Konrad Banachowicz wrote:
> 2012/11/21 Markus Klotzbuecher <markus.klotzbuecher at mech.kuleuven.be>
...

> > > It looks like the problem is cased by libreadline but i am not able to build
> > 
> > Yes, it has do do with the window resize signal being sent. Peter
> > started a thread on the xenomai ML some time ago:
> > 
> > http://thread.gmane.org/gmane.linux.real-time.xenomai.users/11802/focus=11808
> > 
> > AFAIK it was fixed in these two commits:
> > 
> > 89586b71126a06e91a5bbe0ffb510bdaeccd5cf9
> > b73b71edc5e7094ba1e42cb209611105c18ad2a7
> > 
> > I suppose we have to port this fix to rttlua.
> > 
> > > rttlua deployer without libreadline even with NO_GPL set to ON.
> > 
> > Why not?
> Because liblua internally use libreadline.

No, it doesn't, only the REPLs rttlua (ocl/lua/lua-repl.[ch]) or
lua(5.1) do. But you are right, NO_GPL is not honoured by Lua, could
you try the attached patch?

Markus


> From ddd9728092a4d2691267e41589468c7213f51794 Mon Sep 17 00:00:00 2001
From: Markus Klotzbuecher <markus.klotzbuecher at mech.kuleuven.be>
Date: Wed, 21 Nov 2012 11:24:46 +0100
Subject: [PATCH] rttlua: honour NO_GPL

---
 lua/CMakeLists.txt |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/lua/CMakeLists.txt b/lua/CMakeLists.txt
index 56496d1..b8fd7e7 100644
--- a/lua/CMakeLists.txt
+++ b/lua/CMakeLists.txt
@@ -49,13 +49,15 @@ if(BUILD_LUA_RTT)
     install(FILES modules/rttlib.lua modules/ansicolors.lua modules/utils.lua \
modules/rttros.lua DESTINATION usr/share/lua/5.1/)  
     # Handle curses/readline
-    if(NOT CURSES AND NOT READLINE)
+    if(NO_GPL OR (NOT CURSES AND NOT READLINE))
+      if(NOT NO_GPL)
       message(STATUS "Building without readline/curses support. If you want support \
for this try someting like 'sudo aptitude install libncurses5-dev libreadline5-dev'") \
+      endif(NOT NO_GPL)  set(LUA_REPL_FLAGS "-DLUA_ANSI")
-    else(NOT CURSES AND NOT READLINE)
+    else(NO_GPL OR (NOT CURSES AND NOT READLINE))
       set(LUA_REPL_FLAGS "-DLUA_USE_LINUX")
       target_link_libraries(lua-repl "readline" ${CURSES_IMPL} "dl" "history" )
-    endif(NOT CURSES AND NOT READLINE)
+    endif(NO_GPL OR (NOT CURSES AND NOT READLINE))
 
     set_target_properties(lua-repl PROPERTIES COMPILE_FLAGS "${LUA_REPL_FLAGS}")
 
-- 
1.7.10.4


[prev in list] [next in list] [prev in thread] [next in thread]