[prev in list] [next in list] [prev in thread] [next in thread] 

List:       orocos-dev
Subject:    [Orocos-Dev] [Bug 718] Avoid meaningless thread/activity names
From:       peter () thesourceworks ! com (Peter Soetens)
Date:       2009-10-27 10:33:12
Message-ID: E1N2jMW-0006uH-I3 () www ! fmtc ! be
[Download RAW message or body]

https://www.fmtc.be/bugzilla/orocos/show_bug.cgi?id=718


Peter Soetens <peter at thesourceworks.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|                            |FIXED
             Status|NEW                         |RESOLVED




--- Comment #2 from Peter Soetens <peter at thesourceworks.com>  2009-10-27 11:33:12 ---
(In reply to comment #0)
> Created an attachment (id=523)
 --> (https://www.fmtc.be/bugzilla/orocos/attachment.cgi?id=523)
> Set activity name the same as parent taskcontext to ease differencing between
> threads
> 
> When debugging application, it's not very helpful if the logger outputs
> something like
> 
> [kgad at ampere ~]$
> cat debugging.txt
> 0.002 [ Info   ][Thread] Creating Thread for scheduler: 0
> 0.003 [ Info   ][Activity] Thread created with scheduler type '0', priority 0
> and period 0.
> 0.004 [ Info   ][Thread::setScheduler] Setting scheduler type for Thread
> 'Activity' to 1
> 0.004 [ Warning][Thread::setScheduler] Forcing priority (0) of thread with
> !SCHED_OTHER policy to 1.
> 0.006 [ Info   ][Thread] Creating Thread for scheduler: 0
> 0.006 [ Info   ][Activity] Thread created with scheduler type '0', priority 0
> and period 0.
> 0.007 [ Info   ][Hello] Connected Port Port to peer Task Universe.
> 0.008 [ Info   ][Thread] Creating Thread for scheduler: 0
> 0.009 [ Info   ][Activity] Thread created with scheduler type '0', priority 0
> and period 0.
> 0.010 [ Info   ][Thread::setScheduler] Setting scheduler type for Thread
> 'Activity' to 1
> 
> I prefer
> 
> [kgad at ampere ~]$
> cat debugging_after.txt
> 0.002 [ Info   ][Thread] Creating Thread for scheduler: 0
> 0.003 [ Info   ][Hello] Thread created with scheduler type '0', priority 0 and
> period 0.
> 0.004 [ Info   ][Thread::setScheduler] Setting scheduler type for Thread 'Hello'
> to 1
> 0.004 [ Warning][Thread::setScheduler] Forcing priority (0) of thread with
> !SCHED_OTHER policy to 1.
> 0.005 [ Info   ][Thread] Creating Thread for scheduler: 0
> 0.006 [ Info   ][Universe] Thread created with scheduler type '0', priority 0
> and period 0.
> 0.007 [ Info   ][Hello] Connected Port Port to peer Task Universe.
> 0.008 [ Info   ][Thread] Creating Thread for scheduler: 0
> 0.008 [ Info   ][World] Thread created with scheduler type '0', priority 0 and
> period 0.
> 0.009 [ Info   ][Thread::setScheduler] Setting scheduler type for Thread 'World'
> to 1
> 
> Any objections?

Patch applied and back-ported to rtt-1.10.

Peter

-- 
Configure bugmail: https://www.fmtc.be/bugzilla/orocos/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.

[prev in list] [next in list] [prev in thread] [next in thread]