[prev in list] [next in list] [prev in thread] [next in thread] 

List:       orocos-dev
Subject:    [Orocos-Dev] event cdl logic
From:       peter.soetens () fmtc ! be (Peter Soetens)
Date:       2006-03-27 14:06:38
Message-ID: 200603271404.53784.peter.soetens () fmtc ! be
[Download RAW message or body]

On Monday 27 March 2006 13:43, Klaas Gadeyne wrote:
> Hi,
>
> the current event cdl logic contains some flaws, e.g.:
> - OROSEM_CORELIB_EVENTS_AUTOSTART can be enabled without
>    OROSEM_CORELIB_EVENTS_ASYN being enabled
> - One can set properties of the completionprocessor even if it's not
>    running.
>
> Please have a look at the following patch and check if it fixes this
> behaviour.

Seems ok to me.

Peter

>
> regards,
>
> Klaas
>
> Index: corelib/events/current/cdl/events.cdl
> ===================================================================
> --- corelib/events/current/cdl/events.cdl       (revision 267)
> +++ corelib/events/current/cdl/events.cdl       (working copy)
> @@ -25,24 +25,24 @@
>          implements OROINT_CORELIB_COMPLETION_INTERFACE
>       }
>
> -    cdl_option OROSEM_CORELIB_EVENTS_AUTOSTART {
> -       display "Automatically start the CompletionProcessor"
> +    cdl_component OROPKG_CORELIB_EVENTS_CP {
> +       display "Completion Processor Properties"
>          description "
> +The Completion Processor is a thread which processes
> +periodically deferred completion requests of events."
> +        active_if OROSEM_CORELIB_EVENTS_ASYN
> +       flavor none
> +
> +        cdl_option OROSEM_CORELIB_EVENTS_AUTOSTART {
> +           display "Automatically start the CompletionProcessor"
> +           description "
>   This option will enable starting the CompletionProcessor thread
>   automatically in the background so that the application does
>   no longer have to do so."
> -       flavor bool
> -       default_value 1
> +           flavor bool
> +           default_value 1
>       }
>
> -    cdl_component OROPKG_CORELIB_EVENTS_CP {
> -       display "Completion Processor Properties"
> -       description "
> -The Completion Processor is a thread which processes
> -periodically deferred completion requests of events."
> -       flavor none
> -       requires OROSEM_CORELIB_EVENTS_ASYN
> -
>          cdl_option ORODAT_CORELIB_EVENTS_CP_NAME {
>              display "The name of the completion processor"
>              description "
>
>
> _______________________________________________
> Orocos-Dev mailing list
> Orocos-Dev@lists.mech.kuleuven.be
> http://lists.mech.kuleuven.be/mailman/listinfo/orocos-dev

-- 
Peter Soetens -- FMTC -- <http://www.fmtc.be>

[prev in list] [next in list] [prev in thread] [next in thread]