[prev in list] [next in list] [prev in thread] [next in thread] 

List:       oprofile-list
Subject:    [PATCH] Catch and handle error from op_jit_convert function
From:       Maynard Johnson <maynardj () us ! ibm ! com>
Date:       2013-04-19 21:49:56
Message-ID: 5171BC04.8070909 () us ! ibm ! com
[Download RAW message or body]

This patch has been committed already.

--------------------------------------------------------

Catch and handle error from op_jit_convert function

In opjitconv.c:process_jit_dumpfile, we were not detecting a failure
from op_jit_convert, which (when a failure actually does occur there)
results in a very mysterious failure message from copy_elffile().
This patches rectifies that situation.

Signed-off-by: Maynard Johnson <maynardj@us.ibm.com>
---
 opjitconv/opjitconv.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/opjitconv/opjitconv.c b/opjitconv/opjitconv.c
index bd3394e..f4219fb 100644
--- a/opjitconv/opjitconv.c
+++ b/opjitconv/opjitconv.c
@@ -404,6 +404,9 @@ chk_proc_id:
 		}
 		/* Convert the dump file as the special user 'oprofile'. */
 		rc = op_jit_convert(dmp_info, tmp_elffile, start_time, end_time);
+		if (rc < 0)
+			goto free_res3;
+		
 		/* Set eUID back to the original user. */
 		if (!non_root && seteuid(getuid()) != 0) {
 			perror("opjitconv: seteuid to original user failed");
-- 
1.7.1


------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
oprofile-list mailing list
oprofile-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oprofile-list
[prev in list] [next in list] [prev in thread] [next in thread]