[prev in list] [next in list] [prev in thread] [next in thread] 

List:       oprofile-list
Subject:    Re: [RE: PATCH] OProfile testsuite, add operf support to the testsuite
From:       Maynard Johnson <maynardj () us ! ibm ! com>
Date:       2012-09-26 18:41:01
Message-ID: 50634C3D.1040201 () us ! ibm ! com
[Download RAW message or body]

On 09/21/2012 08:52 AM, Maynard Johnson wrote:
> On 09/20/2012 11:27 AM, Carl E. Love wrote:
> > Maynard:
> > 
> > The patch has been updated to include the changes you mentioned in your patch \
> > reviews both on and off the list.
> Thanks, Carl.  This is a really nice addition to the testsuite.
> 
> *Will*, as the person who's previously put the most time into oprofile-tests in the \
> past, please let me know if you have any comments on this patch. 
> -Maynard

Patch committed.  Thanks, Carl.

*Will*, if you ever find time to review this patch, please let me know if you find \
any issues with it.  

-Maynard

> > 
> > Carl Love
> > ------------------------------------------------------------------------------
> > OProfile testsuite, add operf support to the testsuite
> > 
> > This patch adds support for the basic testing of the new
> > operf user interface.  It leverages the existing event
> > tables for the various processors.  OProfile has its own
> > kernel support for the names of the processors.  This
> > information is only available when the OProfile kernel
> > module is loaded.  The operf support gets the CPU name from
> > the ophelp command instead.
> > 
> > The patch also fixes an error in the existing opcontol testsuite.
> > Specifically, the test for the string "opcontrol error:" will always
> > fail because the output from the command does not include the word
> > "opcontrol".  Removed "opcontrol" from the test string.
> > 
> > Added commands to the opcontrol testsuite to make sure the
> > daemonrc file is removed.  This is necessary to ensure there are no
> > extraneous settings, for example filter settings, that will cause errors.
> > 
> > Trailing blanks on five lines in the existing files were removed.
> > 
> > The testsuit for testing OProfile using the opcontrol interface
> > has been renamed to oprofile-opcontrol.  The new testsuite to
> > test OProfile using operf is called oprofile-operf.  To run both
> > testsuites, use the testsuite oprofile.  Specifically the commands
> > to run the testsuites are:
> > 
> > runtest --tool oprofile-opcontrol     // test opcontrol interface
> > 
> > runtest --tool oprofile-operf         // test operf interface
> > 
> > runtest --tool oprofile               // test both interfaces
> > 
> > Signed-off-by: Carl Love <cel@us.ibm.com>
> > ---
> > ---
> > testsuite/README                                   |  31 ++-
> > testsuite/config/unix.exp                          | 112 +++++---
> > testsuite/lib/op_events.exp                        |   4 +-
> > testsuite/lib/op_util.exp                          |  14 +
> > testsuite/lib/operf_util.exp                       | 234 +++++++++++++++++
> > .../oprofile-opcontrol/oprofile-opcontrol-run.exp  | 290 +++++++++++++++++++++
> > testsuite/oprofile-operf/oprofile-operf-run.exp    | 181 +++++++++++++
> > testsuite/oprofile/oprofile-run.exp                | 269 -------------------
> > 8 files changed, 824 insertions(+), 311 deletions(-)
> > create mode 100644 testsuite/lib/operf_util.exp
> > create mode 100644 testsuite/oprofile-opcontrol/oprofile-opcontrol-run.exp
> > create mode 100644 testsuite/oprofile-operf/oprofile-operf-run.exp
> > delete mode 100644 testsuite/oprofile/oprofile-run.exp
> > 
[snip]


------------------------------------------------------------------------------
How fast is your code?
3 out of 4 devs don\\\'t know how their code performs in production.
Find out how slow your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219672;13503038;z?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
_______________________________________________
oprofile-list mailing list
oprofile-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oprofile-list


[prev in list] [next in list] [prev in thread] [next in thread]