[prev in list] [next in list] [prev in thread] [next in thread] 

List:       oprofile-list
Subject:    [PATCH 02/10] opcontrol: fix parameter dump
From:       Robert Richter <robert.richter () amd ! com>
Date:       2009-08-12 15:48:27
Message-ID: 1250092115-14298-3-git-send-email-robert.richter () amd ! com
[Download RAW message or body]

The parameter dump was located in do_init(). Values were printed as
read from the setup file. Parameters that have been updated with a
setup option were wrong. This patch fixes this.

Now, parameters are also dumped if there are no options specified for
--setup. Thus, parameters stored in the setup file can be dumped using
'opcontrol --setup --verbose'.

Signed-off-by: Robert Richter <robert.richter@amd.com>
---
 ChangeLog       |    4 ++++
 utils/opcontrol |   10 ++++++++++
 2 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index ce81dc7..10c54cb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 2009-08-11  Robert Richter <robert.richter@amd.com>
 
+	* utils/opcontrol: fix parameter dump
+
+2009-08-11  Robert Richter <robert.richter@amd.com>
+
 	* utils/opcontrol: fix vecho output
 
 2009-07-31  Maynard Johnson  <maynardj@us.ibm.com>
diff --git a/utils/opcontrol b/utils/opcontrol
index fbea34d..fc92ac7 100644
--- a/utils/opcontrol
+++ b/utils/opcontrol
@@ -404,6 +404,8 @@ do_save_setup()
 	if test "$XEN_RANGE"; then
 		echo "XEN_RANGE=$XEN_RANGE" >> $SETUP_FILE
 	fi
+
+	dump_parameters;
 }
 
 
@@ -865,6 +867,10 @@ do_options()
 	fi
 
 	if test "$SETUP" = "yes" -a "$DO_SETUP" != "yes"; then
+		if test -n "$VERBOSE"; then
+			dump_parameters
+			exit 0
+		fi
 		echo "No options specified for --setup." >&2
 		exit 1
 	fi
@@ -879,7 +885,10 @@ do_options()
 			exit 1
 		fi
 	fi
+}
 
+dump_parameters()
+{
 	vecho "Parameters used:"
 	vecho "SESSION_DIR $SESSION_DIR"
 	vecho "LOCK_FILE   $LOCK_FILE"
@@ -1424,6 +1433,7 @@ do_start_daemon()
 		fi
 	fi
 
+	dump_parameters
 	do_setup
 	check_valid_args
 	get_image_range "linux"
-- 
1.6.4



------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
oprofile-list mailing list
oprofile-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oprofile-list
[prev in list] [next in list] [prev in thread] [next in thread]