[prev in list] [next in list] [prev in thread] [next in thread] 

List:       oprofile-list
Subject:    Re: [PATCH] [1/5] Fix cpuid filter for !arch_perfmon
From:       Suravee Suthikulpanit <suravee.suthikulpanit () amd ! com>
Date:       2009-05-19 17:44:43
Message-ID: 4A12F00B.60406 () amd ! com
[Download RAW message or body]

Andi Kleen wrote:
> 
> Fix a harmless bug I spotted during code review.  When CPUID
> doesn't support arch perfmon always filter everything.
> This cannot happen currently because no non arch perfmon
> event files have filter statements.
> 
> 2009-05-15 Andi Kleen <ak@linux.intel.com>
>         * libop/op_hw_specific.h: (arch_get_filter):
>         Return -1 when CPUID is not available.
> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> 
> ---
>  ChangeLog              |    4 ++++
>  libop/op_hw_specific.h |    2 +-
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> Index: oprofile/libop/op_hw_specific.h
> ===================================================================
> --- oprofile.orig/libop/op_hw_specific.h        2009-05-16 
> 00:27:13.000000000 +0200
> +++ oprofile/libop/op_hw_specific.h     2009-05-16 00:27:17.000000000 +0200
> @@ -61,7 +61,7 @@
>                 workaround_nehalem_aaj79(&ebx);
>                 return ebx & num_to_mask(eax >> 24);
>         }
> -       return 0;
> +       return -1U;
>  }
> 
>  static inline int arch_num_counters(op_cpu cpu_type)
> Index: oprofile/ChangeLog
> ===================================================================
> --- oprofile.orig/ChangeLog     2009-05-16 00:27:13.000000000 +0200
> +++ oprofile/ChangeLog  2009-05-16 00:28:15.000000000 +0200
> @@ -1,3 +1,7 @@
> +2009-05-15 Andi Kleen <ak@linux.intel.com>
> +       * libop/op_hw_specific.h: (arch_get_filter):
> +       Return -1 when CPUID is not available.
> +
>  2009-05-07  Andi Kleen  <ak@linux.intel.com>
>         * utils/ophelp.c:
>         * libop/op_cpu_type.c:
> 

This patch looks fine. I'll go ahead and commit this.

Suravee


------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables 
unlimited royalty-free distribution of the report engine 
for externally facing server and web deployment. 
http://p.sf.net/sfu/businessobjects
_______________________________________________
oprofile-list mailing list
oprofile-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oprofile-list
[prev in list] [next in list] [prev in thread] [next in thread]