[prev in list] [next in list] [prev in thread] [next in thread] 

List:       oprofile-list
Subject:    Re: Misplaced verbose output statements
From:       Maynard Johnson <maynardj () us ! ibm ! com>
Date:       2008-08-27 21:02:55
Message-ID: 48B5C0FF.2010602 () us ! ibm ! com
[Download RAW message or body]

William Cohen wrote:
> Maynard Johnson wrote:
> > William Cohen wrote:
> > > Found that oprofile 0.9.2 opcontrol use to print information about parameters 
> > > when the "--verbose" option was used.  However, some some restructuring of 
> > > opcontrol (2006/11/15) moved that the printing of the information into the 
> > > do_init() function of the opcontrol script. Unfortunately, the "--verbose" 
> > > option haven't been processed yet. Thus, opcontrol never prints out that 
> > > information in oprofile 0.9.3. Attached is a patch developed by Jatin Nansi of 
> > > Red Hat that returns that functionality.  Below is the change log entry.
> > Will,
> > This patch submission got lost in my inbox for a while -- sorry about that.  I \
> > just tried applying it to CVS.  Hunk #2 succeeded with fuzz 1 and offset 728 \
> > lines.  Since the patch was made against 0.9.3, I tried applying it there, also.  \
> > Hunk #2 succeeds again, but with fuzz 2 and offset 16 lines.  In both attempts, \
> > hunk #1 succeeded with some offset, but no fuzz.  I'm not confident the patch \
> > utility would put the patch in the right place, since the context lines don't \
> > exist in either CVS or in oprofile-0.9.3.  Did this 0.9.3 tree in which Jatin \
> > developed the patch have some other modifications? 
> > Can you ask Jatin to manually put the patch into a current CVS tree and re-gen \
> > the patch? 
> > Thanks.
> > -Maynard
> > > -Will
> > > 
> > > 
> > > 2008-07-25  Jatin Nansi <jnansi@redhat.com>
> > > 
> > > 	* utils/opcontrol: Print out after "--verbose" option processed.
> > > 
> > > Signed-off-by: William Cohen <wcohen@redhat.com>
> 
> Hi Maynard,
> 
> Sorry, about the misplaced patch. It was against the oprofile-0.9.3 in rhel 5. 
> There isn't much useful context around the patch, so it was placed in 
> questionable areas. The patch moves the verbose printout from the do_init() to 
> the end of the do_options(), after the point that the verbose option is set. I 
> regenerated the patch on the oprofile cvs and checked that it worked as 
> expected. The attached is the patch against the oprofile cvs.
Applied.  Thanks!

-Maynard
> 
> -Will


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
oprofile-list mailing list
oprofile-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oprofile-list


[prev in list] [next in list] [prev in thread] [next in thread]