[prev in list] [next in list] [prev in thread] [next in thread] 

List:       oprofile-list
Subject:    Re: [oprof-cvs] CVS: oprofile/opjitconv parse_dump.c, 1.1.2.14,
From:       Nathan Scott <nscott () aconex ! com>
Date:       2008-01-20 22:24:58
Message-ID: 1200867898.9463.269.camel () edge ! scott ! net ! au
[Download RAW message or body]

On Fri, 2008-01-18 at 16:04 -0600, Maynard Johnson wrote:
> 
> >>diff -u -p -d -r1.1.2.14 -r1.1.2.15
> >>--- parse_dump.c      16 Jan 2008 15:42:42 -0000      1.1.2.14
> >>+++ parse_dump.c      18 Jan 2008 20:41:23 -0000      1.1.2.15
> >>@@ -59,7 +59,7 @@ static int parse_code_load(void const * 
> >>      padding_count = (((rec->total_size + 7) & 7) ^ 7);
> >> 
> >>      verbprintf(debug, "record0: name=%s, vma=%llx, code_size=%i, "
> >>-                "padding_count=%i, life_start=%lli, life_end=%lli
> \n", entry->symbol_name,
> >>+                "padding_count=%zu, life_start=%lli, life_end=%lli
> \n", entry->symbol_name,
> >>                 entry->vma, entry->code_size, padding_count,
> entry->life_start,
> >>                 entry->life_end);
> >>      /* If end == NULL, the dump does not include code, and this
> sanity
> >>
> > 
> > 
> > I missed this patch on the mail list, I don't think we use %z format
> > specifier, it is unsupported on older gcc version, instead we cast
> > to a sufficient big int to hold the parameter and use the format
> specifier
> > for this type, (%llu unsigned long long).
> Ok, thanks.  I'll make the change. 

"unsigned long" is the right type here, isn't it?  size_t is 32 bits on
32 bit platforms, and 64 bits on 64 bit platforms, I believe...?

We're nitpicking here though, so really either way is fine - as long as
it's always large enough. :)

cheers.

-- 
Nathan


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
oprofile-list mailing list
oprofile-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oprofile-list
[prev in list] [next in list] [prev in thread] [next in thread]