[prev in list] [next in list] [prev in thread] [next in thread] 

List:       oprofile-commits
Subject:    Re: [oprof-cvs] [PATCH] oprofile: use KM_NMI slot for kmap_atomic
From:       Junxiao Bi <junxiao.bi () oracle ! com>
Date:       2012-08-22 7:51:19
Message-ID: 50348F77.2090509 () oracle ! com
[Download RAW message or body]

On 08/22/2012 03:46 PM, Willy Tarreau wrote:
> On Wed, Aug 22, 2012 at 10:21:07AM +0800, Junxiao Bi wrote:
>> If one kernel path is using KM_USER0 slot and is interrupted by
>> the oprofile nmi, then in copy_from_user_nmi(), the KM_USER0 slot
>> will be overwrite and cleared to zero at last, when the control
>> return to the original kernel path, it will access an invalid
>> virtual address and trigger a crash.
>>
>> Cc: Robert Richter <robert.richter@amd.com>
>> Cc: Greg KH <gregkh@linuxfoundation.org>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
>>
>> Hi, Please review this patch.
>>
>> It is for linux-2.6.32.y stable branch not for mainline.
> BTW, is there a mainline equivalent commit ID ? A mainline ID is
> normally needed to merge anything into stable branches to ensure
> that no fix is lost when people upgrade. If this fix is part of
> another mainline commit, that's fine too.
No, mainline doesn't have this issue. It used another way to implement
kmap_atomic, it doesn't need the KM_USER0/KM_NMI0 parameter.
>
> Thanks,
> Willy
>


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Oprofile-commits mailing list
Oprofile-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oprofile-commits
[prev in list] [next in list] [prev in thread] [next in thread]