[prev in list] [next in list] [prev in thread] [next in thread] 

List:       oprofile-commits
Subject:    [oprof-cvs] [SF SCMS]oprofile branch perf-events updated. 0fa5fc43ca2004546864051a584367a50413f190
From:       "Maynard Johnson" <maynardj () users ! sourceforge ! net>
Date:       2012-06-15 19:11:12
Message-ID: E1SfbvQ-0004xI-OP () sfs-ml-4 ! v29 ! ch3 ! sourceforge ! com
[Download RAW message or body]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "oprofile".

The branch, perf-events has been updated
       via  0fa5fc43ca2004546864051a584367a50413f190 (commit)
      from  69442bf017c670c0c78b11456e223b1071a452c6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0fa5fc43ca2004546864051a584367a50413f190
Author: Maynard Johnson <maynardj@us.ibm.com>
Date:   Fri Jun 15 13:55:33 2012 -0500

    Add #include "config.h" before bfd.h for perf-events branch
    
    While building oprofile against a current CVS snapshot of binutils,
    I received the following error:
    
    -----------------------------------------
    make[2]: Entering directory `/home/cseo/at5.0/at5.0-5/src/oprofile/libopagent'
    /bin/sh ../libtool --tag=CC   --mode=compile /opt/at5.0-5-rc1/bin/gcc \
-DHAVE_CONFIG_H -I. -I.. -I/home/cseo/at5.0/at5.0-5/src/oprofile/libopagent    -fPIC \
-I /home/cseo/at5.0/at5.0-5/src/oprofile/libop -I \
/home/cseo/at5.0/at5.0-5/src/oprofile/libutil -g -MT libopagent_la-opagent.lo -MD -MP \
-MF .deps/libopagent_la-opagent.Tpo -c -o libopagent_la-opagent.lo `test -f \
'opagent.c' || echo '/home/cseo/at5.0/at5.0-5/src/oprofile/libopagent/'`opagent.c  \
libtool: compile:  /opt/at5.0-5-rc1/bin/gcc -DHAVE_CONFIG_H -I. -I.. \
-I/home/cseo/at5.0/at5.0-5/src/oprofile/libopagent -fPIC -I \
/home/cseo/at5.0/at5.0-5/src/oprofile/libop -I \
/home/cseo/at5.0/at5.0-5/src/oprofile/libutil -g -MT libopagent_la-opagent.lo -MD -MP \
-MF .deps/libopagent_la-opagent.Tpo -c opagent.c  -fPIC -DPIC -o \
.libs/libopagent_la-opagent.o  In file included from opagent.c:63:0:
    /opt/at5.0-5-rc1/include/bfd.h:37:2: error: #error config.h must be included \
                before this header
    -----------------------------------------
    
    I opened a bug against binutils for this (see \
http://sourceware.org/bugzilla/show_bug.cgi?id=14243),  but the rationale for this \
error was explained to me thusly:  
    "This is a correctness issue.  bfd.h and the headers that bfd.h #include test at
    least one HAVE_* macro.  So you need to include the file that defines those
    HAVE_* macros before bfd.h. [sic] It is a really good idea to always include
    config.h (or sysdep.h or alloca-conf.h that include config.h) before any other
    files, including system headers."
    
    This patch is a minimal patch that addresses the build failure with binutils,
    ensuring that our config.h is #include'd before bfd.h
    
    Since my work on the perf-events branch has involved testing on newer
    binutils, I want to get this fix committed into the perf-events branch now
    so I don't need to be adding a private patch for those times when I build
    with new binutils.
    
    Signed-off-by: Maynard Johnson <maynardj@us.ibm.com>

-----------------------------------------------------------------------

Summary of changes:
 libopagent/opagent.c   |    1 +
 libpp/symbol.h         |    1 +
 opjitconv/debug_line.c |    1 +
 opjitconv/opjitconv.h  |    1 +
 4 files changed, 4 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
oprofile

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Oprofile-commits mailing list
Oprofile-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oprofile-commits


[prev in list] [next in list] [prev in thread] [next in thread]