[prev in list] [next in list] [prev in thread] [next in thread] 

List:       oprofile-commits
Subject:    Re: [oprof-cvs] CVS: oprofile/libregex/tests Makefile.am,1.1,1.2
From:       Philippe Elie <phil.el () wanadoo ! fr>
Date:       2003-09-26 19:06:31
[Download RAW message or body]

John Levon wrote:
> Update of /cvsroot/oprofile/oprofile/libregex/tests
> In directory sc8-pr-cvs1:/tmp/cvs-serv14889/libregex/tests
> 
> Modified Files:
> 	Makefile.am 
> Log Message:
> don't build the tests until "make check" time

I think we must enforce compilation of test through make, it was
one of the point to put tests in oprofile module: ensure the tests
are up to date.

> Index: Makefile.am
> ===================================================================
> RCS file: /cvsroot/oprofile/oprofile/libregex/tests/Makefile.am,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -p -d -r1.1 -r1.2
> --- Makefile.am	26 Sep 2003 02:16:23 -0000	1.1
> +++ Makefile.am	26 Sep 2003 13:45:07 -0000	1.2
> @@ -4,7 +4,7 @@ AM_CPPFLAGS = \
>  
>  AM_CXXFLAGS = @OP_CXXFLAGS@
>  
> -noinst_PROGRAMS = regex_test
> +check_PROGRAMS = regex_test

I really prefer noinst_PROGRAMS, first you can't commit
w/o tests/* *at least* compilable, second if a test
program segfault make check silently fail w/o noticing you
it was a seg fault ... it's usefull to get the tests program
compiled by make then to run them individually.


regards,
Phil



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Oprofile-commits mailing list
Oprofile-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oprofile-commits
[prev in list] [next in list] [prev in thread] [next in thread]